As you'll have inferred, we now have a system set up for doing open code reviews. It's not perfect, but it's pretty nice and very easy to use.

It also generates quite a bit of email - one for each newly posted request, and one (properly threaded) for each comment or other action on that review.

If I understand the capabilities correctly, the software allows each 'review group' to either:

  1. Configure a single mailing list address for the group (of which at
     present we have only the one 'viewer' group)
  2. Leave that address blank

If a list address is configured, all emails for reviews in that group are sent to the list address. If it is left blank, then individual emails are sent to each of the members of the review group.

I chose to configure the opensource-dev list as the mailing list, and the messages do get sent there (as From the user, so the address you configure for your account needs to match the one you use for the list, or that mail will fail).

This will mean a considerable increase in list traffic, I think, since every commit to viewer-development should be reviewed. I think that the increase in transparency of what is happening, and the opportunities for everyone to learn more about more of the code base makes this increase worth it, but am interested in the opinions of other list members.

Note that these emails are easy to set up filters for - not only will all of them have 'Review Request' in the Subject lines, there are also a couple of custom headers in each message that make them easy to recognize.

_______________________________________________
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Reply via email to