----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/26/#review41 -----------------------------------------------------------
Ship it! I think this is correct though I haven't tried the code. Good use of move_inv_category_world_to_agent() that does all the right perm checking. - Merov On 2010-12-16 03:04:28, Kitty Barnett wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/26/ > ----------------------------------------------------------- > > (Updated 2010-12-16 03:04:28) > > > Review request for Viewer. > > > Summary > ------- > > The "Contents" folder is an LLInventoryObject instance, and failed the > dynamic cast to LLInventoryItem. > > The permission logic didn't apply since it's a category (which has no > permissions) and was changed to use the same function that will do the actual > copying so that drop behaviour should always match the "can drop" result. > > > This addresses bug VWR-24217. > http://jira.secondlife.com/browse/VWR-24217 > > > Diffs > ----- > > indra/newview/llpanelobjectinventory.cpp UNKNOWN > > Diff: http://codereview.secondlife.com/r/26/diff > > > Testing > ------- > > > Thanks, > > Kitty > >
_______________________________________________ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges