----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/44/#review58 -----------------------------------------------------------
Ship it! Looks good to me - Brad On 2010-12-19 07:18:51, Aleric Inglewood wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/44/ > ----------------------------------------------------------- > > (Updated 2010-12-19 07:18:51) > > > Review request for Viewer. > > > Summary > ------- > > If tut/tut.hpp isn't installed in a standard include directory all tests > fail because the found include directory for tut isn't passed to the compiler. > > This patch fixes this by passing it. > Note that using include_directories() in a Find*.cmake file is bad practise. > The correct way is to set an include dir variable and call > include_directories() once. It certainly doesn't work for the tests anyway > because the tests are all over the place and include_directories is on a > per folder basis. What is needed is to set it for each (test) target. > > However, there is no TARGET_INCLUDE_DIRECTORIES. The closest thing that we > have is to set the COMPILE_FLAGS property for a target. > > Fortunately, standalone is only used for linux, so we can just use > -I${TUT_INCLUDE_DIR} to get the effect we want. > > > This addresses bug VWR-24251. > http://jira.secondlife.com/browse/VWR-24251 > > > Diffs > ----- > > indra/cmake/LLAddBuildTest.cmake b0689af42a71 > indra/cmake/Tut.cmake b0689af42a71 > indra/test/CMakeLists.txt b0689af42a71 > > Diff: http://codereview.secondlife.com/r/44/diff > > > Testing > ------- > > Tested with standalone and tut.hpp installed in a non-standard place *after > applying VWR-24247* of course. > All tests compile and pass (on linux 64bit). > > > Thanks, > > Aleric > >
_______________________________________________ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
