----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/68/ -----------------------------------------------------------
Review request for Viewer. Summary ------- Environment: Windows, VS 2005 Express Back in the days of v2.1 I was able to supply the following option to develop.py, which would allow me to specify the location of msvcr80.dll msvcp80.dll Microsoft.VC80.CRT.manifest -DMSVC_REDIST_PATH:PATH=E:/some/path There was a similar code path for the debug files -DMSVC_DEBUG_REDIST_PATH=E:/some/path This files cannot be found by the Express compiler so without a way of telling the compiler where to find them they have to be dropped into the build tree manually. At some point Copy3rdPartyLibs.cmake was rewritten and this option was dropped. This addresses bug vwr-24347. http://jira.secondlife.com/browse/vwr-24347 Diffs ----- indra/cmake/Copy3rdPartyLibs.cmake 27dae7b01a81 Diff: http://codereview.secondlife.com/r/68/diff Testing ------- I tried using -DMSVC_REDIST_PATH:PATH=E:/some/path with my VS 2005 Express compiler and obtained the desired result. I don't have the debug files to test -DMSVC_DEBUG_REDIST_PATH=E:/some/path Thanks, Jonathan
_______________________________________________ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges