----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/72/ -----------------------------------------------------------
Review request for Viewer. Summary ------- There is an edge case in setMasterGain during startup which prevents setInternalGain from being called if the master volume setting and mInternalGain both equal 0. Setting mInternalGain to a very low but non-zero value fixes this issue. This addresses bug STORM-830. http://jira.secondlife.com/browse/STORM-830 Diffs ----- indra/llaudio/llaudioengine.cpp 6d44f0d85a80 Diff: http://codereview.secondlife.com/r/72/diff Testing ------- In Preferences / Sound & Media tested: Buttons Ambient Sound Effects Stream Music Media Voice Chat Thanks, Jonathan
_______________________________________________ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges