----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/92/ -----------------------------------------------------------
Review request for Viewer. Summary ------- Added: On linux, when PluginAttachDebuggerToPlugins is set to TRUE, execute the value of the environment variable LL_DEBUG_TERMINAL_COMMAND where a (obligatory) %s is replaced with the contents of the value of the environment variable LL_DEBUG_GDB_PATH followed by the string " -n /proc//exe ", where is the integer of the SLPlugin process we wish to attach to. The default value of LL_DEBUG_TERMINAL_COMMAND, if no environment variable is found, is "/usr/bin/xterm -geometry 160x24+0+0 -e %s" and the default value of LL_DEBUG_GDB_PATH is "/usr/bin/gdb". As such, it is possible to use a different terminal, for example setting the enviroment variable: LL_DEBUG_TERMINAL_COMMAND="/usr/bin/gnome-terminal --geometry=165x24-0+0 -e %s" And you can pass other parameters to gdb (and/or change it's path), for example by setting the enviroment variable: LL_DEBUG_GDB_PATH="/usr/local/bin/gdb -x /home/aleric/mygdbinit" which would open a different gdb and start with executing commands from /home/aleric/mygdbinit (no other .gdbinit is read). This addresses bug VWR-24334. http://jira.secondlife.com/browse/VWR-24334 Diffs ----- doc/contributions.txt b0bd26c5638a indra/llcommon/llprocesslauncher.h b0bd26c5638a indra/llplugin/llpluginprocessparent.cpp b0bd26c5638a Diff: http://codereview.secondlife.com/r/92/diff Testing ------- Thanks, Aleric
_______________________________________________ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges