----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/86/#review160 -----------------------------------------------------------
Ship it! I'm assuming that this global is indeed not used before the new initialization point. - Merov On Jan. 14, 2011, 12:53 p.m., Aleric Inglewood wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/86/ > ----------------------------------------------------------- > > (Updated Jan. 14, 2011, 12:53 p.m.) > > > Review request for Viewer. > > > Summary > ------- > > Fixes this warning. Note that LLCubeMap::sUseCubeMaps is set to true by > default, so this patch only has effect when the feature is actually NOT > available. > > I tested that LLCubeMap::sUseCubeMaps is NOT used before the point where > it is initialized now. > > > This addresses bug VWR-24317. > http://jira.secondlife.com/browse/VWR-24317 > > > Diffs > ----- > > indra/newview/llappviewer.cpp b0bd26c5638a > > Diff: http://codereview.secondlife.com/r/86/diff > > > Testing > ------- > > > Thanks, > > Aleric > >
_______________________________________________ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
