----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/97/#review179 -----------------------------------------------------------
Ship it! Perfect ;) - Aleric On Jan. 17, 2011, 10:03 a.m., Boroondas Gupte wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/97/ > ----------------------------------------------------------- > > (Updated Jan. 17, 2011, 10:03 a.m.) > > > Review request for Viewer. > > > Summary > ------- > > Only use QUIET in pkg_check_modules() on CMake >=2.8.2 (where it's supported) > rather than already on CMake >=2.8. > > > This addresses bug VWR-24520. > http://jira.secondlife.com/browse/VWR-24520 > > > Diffs > ----- > > doc/contributions.txt 9e99b2c8fb28 > indra/cmake/FindLLQtWebkit.cmake 9e99b2c8fb28 > > Diff: http://codereview.secondlife.com/r/97/diff > > > Testing > ------- > > Configured (standalone) without a .pgk file for libllqtwebkit on Linux with > CMake 2.8.1 and CMake 2.8.3. Output as expected. > > Not tested: > * CMake 2.8.2 > * system with a .pgk file for libllqtwebkit > * non-standalone > * Mac, Win > > > Thanks, > > Boroondas > >
_______________________________________________ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
