> On Jan. 18, 2011, 5:58 p.m., Aleric Inglewood wrote: > > I love it! Thanks, this was stopped me from compiling the tests (since some > > commit not long ago I guess, because I could before). > > Just one remark. In one test _PREHASH_AgentID is set to "AgentID" (no doubt > > a place holder), while in the other you set it to 0 (now needed because > > it's a const). Perhaps a more symmetric approach is better? I'd opt for > > setting the other also to a random string, like "Grumpity Productengine", > > or "Aleric Inglewood" now I think about it. Other options are "All Your > > Base Are Belong To Us" and "Hi mom!". Got be SURE they aren't used though > > -- don't want any new 'Grumpity' embarrashments :p > >
Because I don't know how to quote code in a comment, I'll answer in a 'review'. See below. - Boroondas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/100/#review196 ----------------------------------------------------------- On Jan. 18, 2011, 7:29 a.m., Boroondas Gupte wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/100/ > ----------------------------------------------------------- > > (Updated Jan. 18, 2011, 7:29 a.m.) > > > Review request for Viewer. > > > Summary > ------- > > For the reason for this change, see > https://jira.secondlife.com/browse/VWR-24487 and > https://jira.secondlife.com/browse/VWR-24522 > > What I did: > In indra/llmessage/message_prehash.(h|cpp), I turned everything into constant > pointers to constants by search/replace. Then I tried to compile and added > const qualifiers in dependent code as needed to stop the compiler complaining. > > Note that comments in indra/llmessage/message_prehash.(h|cpp) say these files > have been generated from the message template. If this generation wasn't a > one-off thing, the generating code must be changed, too, so it won't override > this change here when the generation happens the next time. > > > This addresses bug VWR-24487. > http://jira.secondlife.com/browse/VWR-24487 > > > Diffs > ----- > > doc/contributions.txt fc7e5dcf3059 > indra/llmessage/message_prehash.h fc7e5dcf3059 > indra/llmessage/message_prehash.cpp fc7e5dcf3059 > indra/llprimitive/llprimitive.h fc7e5dcf3059 > indra/llprimitive/llprimitive.cpp fc7e5dcf3059 > indra/llprimitive/llvolumemessage.h fc7e5dcf3059 > indra/llprimitive/llvolumemessage.cpp fc7e5dcf3059 > indra/llui/tests/llurlentry_stub.cpp fc7e5dcf3059 > indra/newview/tests/llremoteparcelrequest_test.cpp fc7e5dcf3059 > > Diff: http://codereview.secondlife.com/r/100/diff > > > Testing > ------- > > Compiled (standalone, 64bit Linux) with and without LL_TESTS. > Started the viewer, logged in, walked and flew around a bit. Everything seems > to work. > > > Thanks, > > Boroondas > >
_______________________________________________ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
