----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/112/#review242 -----------------------------------------------------------
Ship it! Good code wise. Please keep comments short and clean. indra/newview/llspeakbutton.cpp <http://codereview.secondlife.com/r/112/#comment180> Prefer: // Draw the voice button only if voice chat is enabled indra/newview/skins/default/xui/en/menu_bottomtray.xml <http://codereview.secondlife.com/r/112/#comment179> Please clean up typos (selction, visable, <!--> and <-->) - Merov On Jan. 20, 2011, 9:29 a.m., Wolfpup Lowenhar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/112/ > ----------------------------------------------------------- > > (Updated Jan. 20, 2011, 9:29 a.m.) > > > Review request for Viewer. > > > Summary > ------- > > This is actually a request for for help to debug what I have done so far to > get this working. > 1. In the current diff the button dose actualy hide and show according to if > Voice is enabled or not. > 2. i have two problems at this point. > a. the space taken up by the speak button is not freed up > b. when the speak button is shown after being hidden there is an error > message saying no space avaiable > (I think this is related to the fact that the space is not freed to > begin with). > > > This addresses bug STORM-236. > http://jira.secondlife.com/browse/STORM-236 > > > Diffs > ----- > > doc/contributions.txt 40d0806e9800 > indra/newview/llbottomtray.cpp 40d0806e9800 > indra/newview/llspeakbutton.cpp 40d0806e9800 > indra/newview/skins/default/xui/en/menu_bottomtray.xml 40d0806e9800 > > Diff: http://codereview.secondlife.com/r/112/diff > > > Testing > ------- > > > Thanks, > > Wolfpup > >
_______________________________________________ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
