----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/127/#review280 -----------------------------------------------------------
autobuild/common.py <http://codereview.secondlife.com/r/127/#comment217> The docstring of find_executable should probably indicate that ... autobuild/common.py <http://codereview.secondlife.com/r/127/#comment218> ... the return value is None when no matching executable can be found, as we (somewhat) rely on what the return value is in that case. (Not your fault, the old code already relied on that, too.) autobuild/common.py <http://codereview.secondlife.com/r/127/#comment219> Usually one would test for None with if self._scp is None: as testing for `not self._scp` will also trigger when the value is False (obviously) or (maybe less obvious) becomes False when casted to bool. However, because we don't want self._scp to be an empty string when building the command below ... autobuild/common.py <http://codereview.secondlife.com/r/127/#comment220> ... testing for `not self._scp` here might actually be better, I'm not sure. - Boroondas On Jan. 29, 2011, 5:01 a.m., Oz Linden wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/127/ > ----------------------------------------------------------- > > (Updated Jan. 29, 2011, 5:01 a.m.) > > > Review request for Viewer. > > > Summary > ------- > > During initialization, if there is no scp or pscp command found then > autobuild fails immediately. This is true whether or not any scp urls need > to be used. > > This change modifies the behavior so that a warning is printed if no command > is found, but execution proceeds until an scp command is needed, at which > time execution fails with an explanatory message. > > This patch can print the warning multiple times - I didn't attempt to > suppress the extras. > > > Diffs > ----- > > autobuild/common.py 9ae505976dfa > > Diff: http://codereview.secondlife.com/r/127/diff > > > Testing > ------- > > I've tested this locally, simulating the error by temporarily modifying the > names of the commands to be found for scp. > > I have not checked it on Windows, where the original problem was found. > > > Thanks, > > Oz > >
_______________________________________________ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
