----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/121/#review288 -----------------------------------------------------------
indra/llcommon/llpreprocessor.h <http://codereview.secondlife.com/r/121/#comment222> If we want to pick up 1600, we should just say "== 1600". If we are wary of unknown intermediate VS builds and so want to use inequalities, we should not write the test in such a way that VS9 releases will be identified as VS10 (an hypothetical 15xx). So, I suggest to spell out the whole thing: #if (_MSC_VER < 1400) #define LL_MSVC7 // Visual C++ 2003 or earlier #elif (_MSC_VER < 1500) #define LL_MSVC8 #elif (_MSC_VER < 1600) #define LL_MSVC9 #else #define LL_MSVC10 #endif Note that, that way, your MSVC10 code will not suddenly stop to compile in future versions of MSVC (which is likely to stay backward compatible woth MSVC10). - Merov On Jan. 25, 2011, 11:13 a.m., Nicky Perian wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/121/ > ----------------------------------------------------------- > > (Updated Jan. 25, 2011, 11:13 a.m.) > > > Review request for Viewer. > > > Summary > ------- > > Need additional eyes on this. My first RB. > > > This addresses bug VWR-24610. > http://jira.secondlife.com/browse/VWR-24610 > > > Diffs > ----- > > indra/llcommon/llpreprocessor.h 26c09ad4293e > > Diff: http://codereview.secondlife.com/r/121/diff > > > Testing > ------- > > Compiled with VS2010. Used with another patch around a microsoft bug. Have > not used with VS 2005 > > > Thanks, > > Nicky > >
_______________________________________________ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
