----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/131/#review296 -----------------------------------------------------------
Ship it! Good factorization job. Thanks for doing this. I have not tried the patch though and recommend MM to do a full TC cycle before merging in viewer-development. - Merov On Jan. 31, 2011, 7:34 a.m., Nicky Perian wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/131/ > ----------------------------------------------------------- > > (Updated Jan. 31, 2011, 7:34 a.m.) > > > Review request for Viewer. > > > Summary > ------- > > Copy3rdPartyLibs.cmake need to respond correctly under Visual Studio 10 and > Visual Studio 10 Express Edition. > > > > > This addresses bug VWR-24667. > http://jira.secondlife.com/browse/VWR-24667 > > > Diffs > ----- > > indra/cmake/Copy3rdPartyLibs.cmake 691e3941d950 > > Diff: http://codereview.secondlife.com/r/131/diff > > > Testing > ------- > > Tested good under windows 7 64 bit and Visual Studio 10 Express Edition. > > > Thanks, > > Nicky > >
_______________________________________________ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
