----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/148/#review363 -----------------------------------------------------------
Ship it! The changes look reasonable, and cleanups are always appreciated. :-) Thanks! - Vadim On Feb. 11, 2011, 6:07 a.m., Boroondas Gupte wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/148/ > ----------------------------------------------------------- > > (Updated Feb. 11, 2011, 6:07 a.m.) > > > Review request for Viewer. > > > Summary > ------- > > Rather than relying on (probably anyway accidental) on syntax > incompatibilities, added explicit #error to the indra/llvfs/lldir_*.h headers. > > In separate commits, but also in the diff for review here, removed one such > syntax incompatibility > (https://bitbucket.org/boroondas/open-29/changeset/19ab94811717 ) and did > some cleanup (superfluous "public:"s, trailing whitespace). > > > This addresses bug OPEN-29. > http://jira.secondlife.com/browse/OPEN-29 > > > Diffs > ----- > > doc/contributions.txt ec4ad7e3ecca > indra/llvfs/lldir_linux.h ec4ad7e3ecca > indra/llvfs/lldir_mac.h ec4ad7e3ecca > indra/llvfs/lldir_solaris.h ec4ad7e3ecca > indra/llvfs/lldir_win32.h ec4ad7e3ecca > > Diff: http://codereview.secondlife.com/r/148/diff > > > Testing > ------- > > Built on Linux before pulling > https://bitbucket.org/lindenlab/viewer-development/changeset/7a1440277911 > * Errors out as wanted. > > Build on Linux after pulling 7a1440277911 > * Builds like normal. > > Note: These tests were done with other build fixes present > * for VWR-24520 https://codereview.secondlife.com/r/97/ > * for VWR-24487 https://codereview.secondlife.com/r/100/ > not on a pristine source tree. > > > Thanks, > > Boroondas > >
_______________________________________________ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
