-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/144/
-----------------------------------------------------------

(Updated Feb. 16, 2011, 11:32 a.m.)


Review request for Viewer.


Changes
-------

Updated code per Merov's request and Boroondas' suggestion.


Summary
-------

llmediaplugintest shows up to be compiled even though -DLL_TESTS:BOOL=OFF has 
been used on the command line.

This cmake file does not use the call to LL_ADD_PROJECT_UNIT_TESTS that other 
cmake files do.  

LL_ADD_PROJECT_UNIT_TESTS is usually wrapped with if(LL_TESTS)

I could not figure out which lines suppress the inclusion of 
copy_plugintest_libs and llmediaplugintest into the list of what is to be built 
so wrapped the entire file around if(LL_TESTS).  

If there is some better way to more exactly target these two items please point 
it out.


This addresses bug STORM-977.
    http://jira.secondlife.com/browse/STORM-977


Diffs (updated)
-----

  indra/CMakeLists.txt b0bceb572090 
  indra/test_apps/llplugintest/CMakeLists.txt b0bceb572090 

Diff: http://codereview.secondlife.com/r/144/diff


Testing
-------


Thanks,

Jonathan

_______________________________________________
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Reply via email to