> On Feb. 15, 2011, 6:40 a.m., Vadim ProductEngine wrote: > > indra/newview/llchatbar.h, line 83 > > <http://codereview.secondlife.com/r/139/diff/4/?file=790#file790line83> > > > > Use tabs for indentation, not spaces. > > > > This note seems to apply to all modified lines in this patch. > > Jonathan Yap wrote: > Using spaces is specified in the coding standard: > http://wiki.secondlife.com/wiki/Coding_standard#Indentation > This preference was made explicit on Feb 3. > > Vadim ProductEngine wrote: > Hmmm. This is news to me. Ok, please use tabs anyway to be consistent > with surrounding code.
BTW, the recent change to the coding standard has been rolled back, so tabs are mandatory again. - Vadim ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/139/#review362 ----------------------------------------------------------- On Feb. 18, 2011, 7:11 a.m., Jonathan Yap wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/139/ > ----------------------------------------------------------- > > (Updated Feb. 18, 2011, 7:11 a.m.) > > > Review request for Viewer. > > > Summary > ------- > > This is a request for help. I am trying to learn more about c++ and how > variables in one class are accessed from another. For someone who knows what > they are doing this is probably a pretty easy question. > > I have been able to set the font size on the chat input box when it is > created in llbottomtray.cpp. I would like to do the same thing when someone > clicks in that box to input text; it is possible they have changed the font > setting and I would like to apply the size there as well, but I am stuck on > how to do this. I think the right place to do this is in > llchatbar.cpp/LLChatBar::onInputEditorGainFocus(). > > I have tried all kinds of wrong ways but at this point am stymied. > > Exact steps on how to proceed would be appreciated. > > > This addresses bug vwr-22220. > http://jira.secondlife.com/browse/vwr-22220 > > > Diffs > ----- > > indra/newview/llbottomtray.h 3d2e71443c58 > indra/newview/llbottomtray.cpp 3d2e71443c58 > indra/newview/llchatbar.h 3d2e71443c58 > indra/newview/llchatbar.cpp 3d2e71443c58 > > Diff: http://codereview.secondlife.com/r/139/diff > > > Testing > ------- > > > Thanks, > > Jonathan > >
_______________________________________________ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
