----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/168/ -----------------------------------------------------------
Review request for Viewer and Aleric Inglewood. Summary ------- On standalone, -I"${TUT_INCLUDE_DIR}" was added to the compile flags for integration tests of llcommon when TUT_INCLUDE_DIR might not have been set yet. This lead to a flag -I"", which would confuse g++ and lead to the tests' object files not being found. This change makes sure that TUT_INCLUDE_DIR is set by including Tut.cmake, which is responsible for setting it. This addresses bug OPEN-39. http://jira.secondlife.com/browse/OPEN-39 Diffs ----- doc/contributions.txt 1013caf84c2e indra/cmake/LLAddBuildTest.cmake 1013caf84c2e Diff: http://codereview.secondlife.com/r/168/diff Testing ------- Clean rebuild with LL_TESTS ON (see also repro instructions on jira) Thanks, Boroondas
_______________________________________________ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges