----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/171/#review423 -----------------------------------------------------------
Ship it! Seems to be correct to me. - Merov On March 3, 2011, 11:52 a.m., Oz Linden wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/171/ > ----------------------------------------------------------- > > (Updated March 3, 2011, 11:52 a.m.) > > > Review request for Viewer. > > > Summary > ------- > > This patch removes the two "Hide URL" checkboxes in the parcel management > screens. > The corresponding flags are not removed from the messages exchanged with > server in order to preserve backward compatibility; instead, they are always > sent as 'false' (show the url), and are ignored when received. > > > This addresses bug storm-1037. > http://jira.secondlife.com/browse/storm-1037 > > > Diffs > ----- > > indra/llinventory/llparcel.h 8596ccc522d9 > indra/llinventory/llparcel.cpp 8596ccc522d9 > indra/newview/llfloaterauction.cpp 8596ccc522d9 > indra/newview/llpanellandaudio.cpp 8596ccc522d9 > indra/newview/llpanellandmedia.cpp 8596ccc522d9 > indra/newview/llpanelnearbymedia.cpp 8596ccc522d9 > indra/newview/skins/default/xui/da/floater_about_land.xml 8596ccc522d9 > indra/newview/skins/default/xui/de/floater_about_land.xml 8596ccc522d9 > indra/newview/skins/default/xui/en/floater_about_land.xml 8596ccc522d9 > indra/newview/skins/default/xui/es/floater_about_land.xml 8596ccc522d9 > indra/newview/skins/default/xui/fr/floater_about_land.xml 8596ccc522d9 > indra/newview/skins/default/xui/it/floater_about_land.xml 8596ccc522d9 > indra/newview/skins/default/xui/ja/floater_about_land.xml 8596ccc522d9 > indra/newview/skins/default/xui/nl/floater_about_land.xml 8596ccc522d9 > indra/newview/skins/default/xui/pl/floater_about_land.xml 8596ccc522d9 > indra/newview/skins/default/xui/pt/floater_about_land.xml 8596ccc522d9 > > Diff: http://codereview.secondlife.com/r/171/diff > > > Testing > ------- > > Verified that the checkboxes are no longer present, and that media can be set > using either dialog. > > > Thanks, > > Oz > >
_______________________________________________ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
