----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/182/#review433 -----------------------------------------------------------
Ship it! Seems good. - Merov On March 7, 2011, 4:44 p.m., Boroondas Gupte wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/182/ > ----------------------------------------------------------- > > (Updated March 7, 2011, 4:44 p.m.) > > > Review request for Viewer. > > > Summary > ------- > > Searched all uses of the copy_if_different CMake macro, and where variables > were passed as arguments, double-quoted them. > > > This addresses bug OPEN-36. > http://jira.secondlife.com/browse/OPEN-36 > > > Diffs > ----- > > indra/cmake/Copy3rdPartyLibs.cmake ed35dc91644b > indra/copy_win_scripts/CMakeLists.txt ed35dc91644b > indra/test_apps/llplugintest/CMakeLists.txt ed35dc91644b > > Diff: http://codereview.secondlife.com/r/182/diff > > > Testing > ------- > > Successfully configured with > autobuild configure -c OpenSourceStandAloneRelWithDebInfo > > (Building still fails due to unrelated issues.) > > > Thanks, > > Boroondas > >
_______________________________________________ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges