----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/195/ -----------------------------------------------------------
(Updated March 10, 2011, 10:15 p.m.) Review request for Viewer. Changes ------- Took Vadim's private comments into account: - added more arguments consistency checking - flushed perf data when done with images so that there's something in the slp file, even for small amount of data analyzed Summary ------- This creates a new independent executable that exercise the entire llimage libray, loading and saving all supported image file formats, gathering perf data and outputting basic image info. The use of the application itself is documented in the wiki: https://wiki.secondlife.com/wiki/Llimage_libtest >From a code standpoint, the main things done are: - Add a new test application in indra/integration_tests/llimage_libtest/ - Move some perf amalyzing code from indra/newview/llfasttimerview.cpp to indra/llcommon/llmetricperformancetester so that it can be used outside the newview context (as it should...) - Small cleanup in llimage.h This addresses bug STORM-987. http://jira.secondlife.com/browse/STORM-987 Diffs (updated) ----- indra/integration_tests/CMakeLists.txt 344d4c6d7d7e indra/integration_tests/llimage_libtest/CMakeLists.txt PRE-CREATION indra/integration_tests/llimage_libtest/llimage_libtest.h PRE-CREATION indra/integration_tests/llimage_libtest/llimage_libtest.cpp PRE-CREATION indra/llcommon/llmetricperformancetester.h 344d4c6d7d7e indra/llcommon/llmetricperformancetester.cpp 344d4c6d7d7e indra/llimage/llimage.h 344d4c6d7d7e indra/llimage/llimagej2c.cpp 344d4c6d7d7e indra/newview/llfasttimerview.h 344d4c6d7d7e indra/newview/llfasttimerview.cpp 344d4c6d7d7e Diff: http://codereview.secondlife.com/r/195/diff Testing ------- So far, testing has been done on Mac only. Tests on Windows and Linux are planned and will likely result in cmake tweaks here and there. We're not planning however to alter dramatically this code further at this point. Thanks, Merov
_______________________________________________ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
