----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/199/ -----------------------------------------------------------
Review request for Viewer. Summary ------- I looking at the code, trying to find out where/how to add a new feature, when I tripped across one of these and it lit my mental warning bells off. Vector distance comparisons should, IMHO, always be done squared. So I did some greppin, manual analysis, and some careful modification, and here's the result. This addresses bug https://jira.secondlife.com/browse/VWR-25126. http://jira.secondlife.com/browse/https://jira.secondlife.com/browse/VWR-25126 Diffs ----- doc/contributions.txt 344d4c6d7d7e indra/llcharacter/llbvhloader.cpp 344d4c6d7d7e indra/llmath/tests/llbbox_test.cpp 344d4c6d7d7e indra/newview/llagent.cpp 344d4c6d7d7e indra/newview/llfloaterchat.cpp 344d4c6d7d7e indra/newview/llhudeffectlookat.cpp 344d4c6d7d7e indra/newview/llhudeffectpointat.cpp 344d4c6d7d7e indra/newview/llmaniprotate.cpp 344d4c6d7d7e indra/newview/llmanipscale.cpp 344d4c6d7d7e indra/newview/llnetmap.cpp 344d4c6d7d7e indra/newview/llpanelpeople.cpp 344d4c6d7d7e indra/newview/llselectmgr.cpp 344d4c6d7d7e indra/newview/llspeakers.cpp 344d4c6d7d7e indra/newview/llviewerchat.cpp 344d4c6d7d7e indra/newview/llvoicevivox.cpp 344d4c6d7d7e indra/newview/llworld.cpp 344d4c6d7d7e Diff: http://codereview.secondlife.com/r/199/diff Testing ------- Compiled a test viewer and used it, undertaking some of my normal activities. Results felt good, but are currently anecdotal. Any suggestions on how to properly measure this (or even some actual measurement from those already instrumented to measure these things,) would be great! Thanks, Cron
_______________________________________________ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
