> On March 17, 2011, 4:50 a.m., Vadim ProductEngine wrote: > > indra/newview/llnetmap.cpp, lines 473-474 > > <http://codereview.secondlife.com/r/197/diff/4/?file=1208#file1208line473> > > > > Please move these numbers to settings.
Those two should be CHAT_NORMAL_RADIUS and CHAT_SHOUT_RADIUS respectively. Both are defined in indra_constants.h in the llcommon directory. - Cron ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/197/#review473 ----------------------------------------------------------- On March 12, 2011, 8 a.m., Jonathan Yap wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/197/ > ----------------------------------------------------------- > > (Updated March 12, 2011, 8 a.m.) > > > Review request for Viewer. > > > Summary > ------- > > Add optional range ring to the mini-map -- one centered on you with a radius > of 20m to show local chat range. > > By default the range ring is off. > > To turn it on you right click on the mini-map and pick the menu entry "Range > Ring". > > > This addresses bug Storm-1068. > http://jira.secondlife.com/browse/Storm-1068 > > > Diffs > ----- > > doc/contributions.txt aed94e854443 > indra/newview/app_settings/settings.xml aed94e854443 > indra/newview/llnetmap.h aed94e854443 > indra/newview/llnetmap.cpp aed94e854443 > indra/newview/skins/default/colors.xml aed94e854443 > indra/newview/skins/default/xui/en/menu_mini_map.xml aed94e854443 > > Diff: http://codereview.secondlife.com/r/197/diff > > > Testing > ------- > > Tested with another avatar. When they are outside the ring they cannot see > my local chat and when they are inside it they can, so the ring's radius is > set correctly. > > Flew over various types of land to make sure my color choice (blue @10%) was > always visible. > > Enabled range ring, logged out and back on; range ring is still present on > mini-map. > > Panned mini-map, range ring remains centered over avatar. > > Used mouse wheel to zoom in and out as far as possible. Size of range ring > varied with change in zoom level. > > > Thanks, > > Jonathan > >
_______________________________________________ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
