----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/215/#review485 -----------------------------------------------------------
Ship it! Even better than my solution - Oz On March 17, 2011, 3:02 p.m., Alain Linden wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/215/ > ----------------------------------------------------------- > > (Updated March 17, 2011, 3:02 p.m.) > > > Review request for Viewer, Oz Linden and Boroondas Gupte. > > > Summary > ------- > > Suggested fix for OPEN-45. I'd like to decouple Executable as much as > possible from assumptions and state of autobuild. To that end I added an > optional argument to the __str__ method to accept an options list to insert > into the command string. The command string generated by __call__ and > __str__ is now identical. Incidentally I made the environment an optional > argument to __call__ to make it more general and decouple it a little more > from the rest of autobuild. > > > This addresses bug OPEN-45. > http://jira.secondlife.com/browse/OPEN-45 > > > Diffs > ----- > > autobuild/autobuild_tool_build.py abc1014d5ad6 > autobuild/autobuild_tool_configure.py abc1014d5ad6 > autobuild/common.py abc1014d5ad6 > autobuild/executable.py abc1014d5ad6 > > Diff: http://codereview.secondlife.com/r/215/diff > > > Testing > ------- > > > Thanks, > > Alain > >
_______________________________________________ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
