-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/245/
-----------------------------------------------------------
Review request for Viewer.
Summary
-------
Resolved Linux file descriptor greediness by removing obsolete fallback font
searching (call to LLWindowSDL::getDynamicFallbackFontList()), as this seems to
be obsolete unless your skin's configuration references font files that are not
packaged with the viewer, which is not the default case. Would like to know if
this solves the instability described in STORM-1122 for Linux users,
particularly those with lower than average file descriptor limits set (find out
by running `ulimit -a`, it's the value 'open files', mine is 1024 on Ubuntu
10.10 and I'd have extreme problems prior to the patch).
This addresses bug STORM-1122.
http://jira.secondlife.com/browse/STORM-1122
Diffs
-----
doc/contributions.txt a8f868007986
indra/llwindow/llwindow.cpp a8f868007986
Diff: http://codereview.secondlife.com/r/245/diff
Testing
-------
Useful ways to examine file descriptor usage for the viewer
lsof -c do-not | less
This should be much, much less than 1024
lsof -c do-not | wc -l
This shows all descriptors containing the word 'font' along with the number of
each (there are tons of duplicates)
lsof -c do-not | egrep -o '[^ ]*font[^ ]*' | sort | uniq -c | less
Thanks,
Discrete
_______________________________________________
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges
