-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/242/#review529
-----------------------------------------------------------
Ship it!
Looks good.
Empty-string ("") is a signal to curl to send an Accept-Encoding header with
any type it understands and can transparently decode on receipt. On the one
hand, it might be nice to define a constant empty string so that this behavior
is more obvious, but on the other using literal empty strings will match what
people might search for.
- Joshua
On March 31, 2011, 7:32 a.m., Stone Linden wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/242/
> -----------------------------------------------------------
>
> (Updated March 31, 2011, 7:32 a.m.)
>
>
> Review request for Viewer, Oz Linden, Joshua Linden, and Brad Kittenbrink.
>
>
> Summary
> -------
>
> Enable Accept-Encoding: deflate, gzip in libcurl via setopt CURLOPT_ENCODING.
> I'm approaching this for Inventory, but it would apply to any HTTP request
> that goes through the LLURLRequest code path (vs. the LLCurl code path, which
> already does this).
>
>
> This addresses bug vwr-25376.
> http://jira.secondlife.com/browse/vwr-25376
>
>
> Diffs
> -----
>
> indra/llmessage/llurlrequest.cpp 2ae060c0fa91
>
> Diff: http://codereview.secondlife.com/r/242/diff
>
>
> Testing
> -------
>
> Inventory loads, and I see the encoding options coming through on the backend
> apache logs.
>
>
> Thanks,
>
> Stone
>
>
_______________________________________________
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges
