-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/252/
-----------------------------------------------------------
(Updated April 8, 2011, 10:26 a.m.)
Review request for Viewer.
Changes
-------
I changed the description of the review: added the possible causes of this bug.
I regenerated the viewer-development-storm-973 branch based on the latest
viewer-development branch. If you still can not apply the patch directly, I am
afraid you should do the manual merge. Otherwise grant me the permission, I
will do it.
Summary (updated)
-------
this is to resubmit the patch for storm-973.
We are not very clear what causes this. But this fix is targeting three most
possible causes:
1, a texture is failed to add into mImageList but its flag is set to be
successful;
2, a texture status is changed not from the main thread, because gTextureList
is not thread-safe;
3, gTextureList is accessed before it is initialized.
I regenerated the viewer-development-storm-973 branch based on the latest
viewer-development branch. If you still can not apply the patch directly, I am
afraid you should do the manual merge. Otherwise grant me the permission, I
will do it.
This addresses bug storm-973.
http://jira.secondlife.com/browse/storm-973
Diffs
-----
indra/newview/lldrawpoolbump.cpp 13670741a0a8
indra/newview/llviewertexturelist.h 13670741a0a8
indra/newview/llviewertexturelist.cpp 13670741a0a8
Diff: http://codereview.secondlife.com/r/252/diff
Testing
-------
Thanks,
Xiaohong
_______________________________________________
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges
