----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/271/#review637 -----------------------------------------------------------
indra/llui/llnotifications.cpp <http://codereview.secondlife.com/r/271/#comment608> LLNotificationsUtil is a wrapper around LLNotifications. Calling a wrapper from the class it wraps doesn't look very nice to me. So I'd change this line to do the following: add(name.asString(), LLSD(), LLSD()); and remove the include. Both approaches trigger a run-time warning though. I'll address that in a separate review request (coming soon). - Vadim On April 19, 2011, 7:57 a.m., Ima Mechanique wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/271/ > ----------------------------------------------------------- > > (Updated April 19, 2011, 7:57 a.m.) > > > Review request for Viewer. > > > Summary > ------- > > Applying Kitty Barnett's patch against current code base. > > > This addresses bug STORM-1175. > http://jira.secondlife.com/browse/STORM-1175 > > > Diffs > ----- > > doc/contributions.txt 584211e99147 > indra/llui/llnotifications.cpp 584211e99147 > > Diff: http://codereview.secondlife.com/r/271/diff > > > Testing > ------- > > Release build. tested preferences both in world and on the log in screen. > > > Thanks, > > Ima > >
_______________________________________________ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
