----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/275/#review640 -----------------------------------------------------------
Ship it! Looks fine to me. - Vadim On April 20, 2011, 2:33 p.m., Jonathan Yap wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/275/ > ----------------------------------------------------------- > > (Updated April 20, 2011, 2:33 p.m.) > > > Review request for Viewer. > > > Summary > ------- > > From the jira Description: > Griefers are still able to spam you with dialogs, such as dialogs, web site > popups, and avatar animation requests even after you mute the owner of the > object. Muting does not stop these at all. This is an ideal path for griefers > to attack and they have been doing so for as long as I've been on Second > Life. I believe that muting the object or it's owner should stop dialogs of > all types from appearing from the object. > > Note: > The changes to message_template.msg are not mine; that file was pushed from > the server source into viewer-development. I have no control over what goes > into that file or how it is formatted, etc. > > > This addresses bug Storm-956. > http://jira.secondlife.com/browse/Storm-956 > > > Diffs > ----- > > doc/contributions.txt ec4ad7e3ecca > indra/newview/llviewermessage.cpp ec4ad7e3ecca > scripts/messages/message_template.msg ec4ad7e3ecca > > Diff: http://codereview.secondlife.com/r/275/diff > > > Testing > ------- > > See lengthy Test Plan in the jira. > > > Thanks, > > Jonathan > >
_______________________________________________ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges