----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/280/#review655 -----------------------------------------------------------
Ship it! The nice thing about this change is that is has to be correct[*] if it still compiles. (And it does, I checked :-) 3 minor considerations: indra/llxml/llcontrol.cpp <http://codereview.secondlife.com/r/280/#comment618> 1) Any reason not to do the same for name? 2) Remove space between "const" and "&", so that it's easer to visually distinguish from binary operator & 3) LLSD::map_const_iterator seems to support operator ->, so we could write itr->second instead of (*itr).second . [*] Assuming the data referenced by control_map isn't changed by other threads meanwhile. But I guess that'd also be necessary for copying it correctly, isn't it? - Boroondas On April 26, 2011, 5:36 p.m., Brad Kittenbrink wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/280/ > ----------------------------------------------------------- > > (Updated April 26, 2011, 5:36 p.m.) > > > Review request for Viewer. > > > Summary > ------- > > Unnecessary copying was slowing down debugging of STORM-1141. > > > This addresses bug VWR-25610. > http://jira.secondlife.com/browse/VWR-25610 > > > Diffs > ----- > > indra/llxml/llcontrol.cpp UNKNOWN > > Diff: http://codereview.secondlife.com/r/280/diff > > > Testing > ------- > > > Thanks, > > Brad > >
_______________________________________________ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
