> On April 27, 2011, 2:16 a.m., Boroondas Gupte wrote: > > indra/llcommon/CMakeLists.txt, lines 262-278 > > <http://codereview.secondlife.com/r/281/diff/1/?file=1517#file1517line262> > > > > Naive question: Is there a reason not to add /DEBUG also when NOT > > LLCOMMON_LINK_SHARED?
The /DEBUG linker flag doesn't really apply for static libraries since the linker doesn't run for static libraries on windows. The debug information is already embedded in our .lib static libraries on windows. - Brad ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/281/#review653 ----------------------------------------------------------- On April 26, 2011, 5:48 p.m., Brad Kittenbrink wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/281/ > ----------------------------------------------------------- > > (Updated April 26, 2011, 5:48 p.m.) > > > Review request for Viewer. > > > Summary > ------- > > Somewhere in the VS2010 transition, the default conventions changed for how > .pdb files get generated on shared library targets. This fix explicitly sets > the /DEBUG flag for the linker on the llcommon target. > > > This addresses bug CHOP-629. > http://jira.secondlife.com/browse/CHOP-629 > > > Diffs > ----- > > indra/llcommon/CMakeLists.txt UNKNOWN > > Diff: http://codereview.secondlife.com/r/281/diff > > > Testing > ------- > > I tested locally in the debugger, but I did not test crash reports. We > should find a way to test that once my TC build completes. > > > Thanks, > > Brad > >
_______________________________________________ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
