----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/282/#review666 -----------------------------------------------------------
Ship it! Looks good to me. - Brad On May 1, 2011, 2:54 p.m., Boroondas Gupte wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/282/ > ----------------------------------------------------------- > > (Updated May 1, 2011, 2:54 p.m.) > > > Review request for Viewer. > > > Summary > ------- > > curl_escape() returns a pointer to a C-string. When one is done with the > C-string, one must curl_free() the pointer. (See > http://curl.haxx.se/libcurl/c/curl_escape.html .) To be able to call > curl_free on the pointer, we must keep it in the first place. > > Also, a cpp file in which curl functions are called should include > <curl/curl.h> directly, even if it already gets included indirectly, i.e. via > other includes. So adding that, too. > > > Note that curl_escape() is deprecated and should be replaced by > curl_easy_escape(). This change does not do that, as this should probably be > done for all occurrences at once and be accompanied by some refactoring. > > > This addresses bug VWR-25654. > http://jira.secondlife.com/browse/VWR-25654 > > > Diffs > ----- > > doc/contributions.txt 9ff8625cadec > indra/newview/lltranslate.cpp 9ff8625cadec > > Diff: http://codereview.secondlife.com/r/282/diff > > > Testing > ------- > > * Built Viewer (Linux 64bit STANDALONE) > * Verified that translation still works (logged in, enabled translation in > nearby chat floater, changed "translate to" language in preferences > chat > and went to Ahern) > > > Thanks, > > Boroondas > >
_______________________________________________ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
