-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/351/
-----------------------------------------------------------

Review request for Viewer.


Summary
-------

These flags prevent building for 64-bit (both standalone or non-standalone), so 
only use them for 32-bit builds.


This addresses bug OPEN-99.
    http://jira.secondlife.com/browse/OPEN-99


Diffs
-----

  doc/contributions.txt e8f2a53c3d6e 
  indra/cmake/00-Common.cmake e8f2a53c3d6e 

Diff: http://codereview.secondlife.com/r/351/diff


Testing
-------

Tried a non-standalone 64-bit build (without using 64-bit prebuilts, though):
Fails with
        [ 11%] Building CXX object llcommon/CMakeFiles/llcommon.dir/u64.o
        Linking CXX shared library libllcommon.so
        
/usr/lib/gcc/x86_64-pc-linux-gnu/4.4.5/../../../../x86_64-pc-linux-gnu/bin/ld: 
skipping incompatible 
${SRC_DIR}/build-linux-i686/packages/lib/release/libbreakpad_client.so when 
searching for -lbreakpad_client
        
/usr/lib/gcc/x86_64-pc-linux-gnu/4.4.5/../../../../x86_64-pc-linux-gnu/bin/ld: 
skipping incompatible 
${SRC_DIR}/build-linux-i686/packages/lib/release/libaprutil-1.so when searching 
for -laprutil-1
        
/usr/lib/gcc/x86_64-pc-linux-gnu/4.4.5/../../../../x86_64-pc-linux-gnu/bin/ld: 
skipping incompatible 
${SRC_DIR}/build-linux-i686/packages/lib/release/libaprutil-1.a when searching 
for -laprutil-1
        
/usr/lib/gcc/x86_64-pc-linux-gnu/4.4.5/../../../../x86_64-pc-linux-gnu/bin/ld: 
skipping incompatible 
${SRC_DIR}/build-linux-i686/packages/lib/release/libdb-5.1.so when searching 
for -ldb-5.1
        
/usr/lib/gcc/x86_64-pc-linux-gnu/4.4.5/../../../../x86_64-pc-linux-gnu/bin/ld: 
cannot find -ldb-5.1
        collect2: ld returned 1 exit status
        make[2]: *** [llcommon/libllcommon.so] Error 1
        make[1]: *** [llcommon/CMakeFiles/llcommon.dir/all] Error 2
        make: *** [all] Error 2
        ERROR: building default configuration returned 2
        For more information: try re-running your command with --verbose or 
--debug

Tried a standalone 64-bit build (after merging OPEN-38 changes):
Fails with
        [ 13%] Building CXX object 
llcharacter/CMakeFiles/llcharacter.dir/llvisualparam.o
        Linking CXX static library libllcharacter.a
        [ 13%] Built target llcharacter
        Scanning dependencies of target INTEGRATION_TEST_bitpack
        [ 13%] Building CXX object 
llcommon/CMakeFiles/INTEGRATION_TEST_bitpack.dir/tests/bitpack_test.o
        c++: CMakeFiles/INTEGRATION_TEST_bitpack.dir/tests/bitpack_test.o: No 
such file or directory
        make[2]: *** 
[llcommon/CMakeFiles/INTEGRATION_TEST_bitpack.dir/tests/bitpack_test.o] Error 1
        make[1]: *** [llcommon/CMakeFiles/INTEGRATION_TEST_bitpack.dir/all] 
Error 2
        make: *** [all] Error 2
        ERROR: building default configuration returned 2
        For more information: try re-running your command with --verbose or 
--debug

(Both errors occur much later in the build process than the one that'd occur 
without this change.)

Tried a non-standalone 32-bit build:
Fails on https://jira.secondlife.com/browse/OPEN-23 , just as without this 
change.


Thanks,

Boroondas

_______________________________________________
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Reply via email to