----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/370/#review826 -----------------------------------------------------------
Looks good apart from missing NULL check. indra/newview/llpanelwearing.cpp <http://codereview.secondlife.com/r/370/#comment840> I'd use const_iterator instead. indra/newview/llpanelwearing.cpp <http://codereview.secondlife.com/r/370/#comment841> A bit of code duplication. I'd rewrite it like this: ///////////////////////////////// if (!need_cr) { need_cr = true; } else { text += "\n"; } text += item->getName(); ///////////////////////////////// Please also make sure the item is not NULL to prevent a crash. - Vadim On June 29, 2011, 7:32 a.m., Jonathan Yap wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/370/ > ----------------------------------------------------------- > > (Updated June 29, 2011, 7:32 a.m.) > > > Review request for Viewer. > > > Summary > ------- > > Add a feature on the "Wearing TAB" where users could copy to the clipboard > everything you see in the "Wearing TAB". This would make the blogging > communities life soooooo much easier instead of having to type out all that > information. > > The label on this button needs input from someone on the XD team. > > I would like to know if my code for adding a CR to the end of every line but > the last one could be done in a more elegant way. > > > This addresses bug STORM-1459. > http://jira.secondlife.com/browse/STORM-1459 > > > Diffs > ----- > > doc/contributions.txt f9864a43ddf0 > indra/newview/llpanelwearing.h f9864a43ddf0 > indra/newview/llpanelwearing.cpp f9864a43ddf0 > indra/newview/skins/default/xui/en/panel_outfits_wearing.xml f9864a43ddf0 > > Diff: http://codereview.secondlife.com/r/370/diff > > > Testing > ------- > > Clicked on Send to Clipboard button and was able to paste results into an > editor. > > > Thanks, > > Jonathan > >
_______________________________________________ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
