----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/377/ -----------------------------------------------------------
Review request for Viewer. Summary ------- This is a direct adaptation of Aimee Trescothick's contributed patch from STORM-1315 for v-d. Adjustments were made where needed to make it work with the newer boost and llui code. Some changes were made to the variable names it uses on build; ie "PX" for x position instead of just "X". Patch allows for imputing simple math equations in to the spinner controls. On the build floater a series of variable names are available for using the objects current values in equations, like "sx+3" will take the current X scale and add 3. Repo: https://bitbucket.org/Kadah_Coba/storm-1315 Changeset: https://bitbucket.org/Kadah_Coba/storm-1315/changeset/d33ca6edf370 This addresses bug STORM-1315. http://jira.secondlife.com/browse/STORM-1315 Diffs ----- doc/contributions.txt UNKNOWN indra/llmath/CMakeLists.txt UNKNOWN indra/llmath/llcalc.h UNKNOWN indra/llmath/llcalc.cpp UNKNOWN indra/llmath/llcalcparser.h UNKNOWN indra/llmath/llcalcparser.cpp UNKNOWN indra/llui/lllineeditor.h UNKNOWN indra/llui/lllineeditor.cpp UNKNOWN indra/llui/llspinctrl.cpp UNKNOWN indra/newview/llappviewer.cpp UNKNOWN indra/newview/llpanelface.cpp UNKNOWN indra/newview/llpanelobject.cpp UNKNOWN Diff: http://codereview.secondlife.com/r/377/diff Testing ------- Built and ran. Some testing done with simple equations on the build tools floater to edit an object, no issues were observed. Thanks, Kadah
_______________________________________________ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
