> On July 25, 2011, 7:50 a.m., Vadim ProductEngine wrote: > > indra/newview/skins/minimal/xui/da/panel_people.xml, line 69 > > <http://codereview.secondlife.com/r/387/diff/1/?file=6607#file6607line69> > > > > Missing rename here. > > Boroondas Gupte wrote: > For some reason I thought STORM-1403 was only about the "My Friends" tab > of "People" floater, but re-reading the issue, it is indeed about all of the > "People" floater, even thought the explicitly mentioned labels are all from > the "My Friends" tab, so you are right that this element should have been > renamed, too.
Err ... wait ... this /is/ about the same 'My Friends' tab. (Sorry, it's a while ago I worked on this issue.) I did not rename this because I assumed that was the proper name for the layout_panel containing the im_btn, and that the following entries (for call and teleport) had duplicate names because they were copied from it. Looking at the name inconsistency, it might be that actually all 3 buttons have been copied from the group_chat_btn on the other tab. - Boroondas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/387/#review917 ----------------------------------------------------------- On July 18, 2011, 10:53 a.m., Boroondas Gupte wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/387/ > ----------------------------------------------------------- > > (Updated July 18, 2011, 10:53 a.m.) > > > Review request for Viewer. > > > Summary > ------- > > The layout_panels containing the buttons didn't have unique names. > Renamed them so that their names are now unique within their parent > element. > > Removed the share_btn element and containing layout_panel from translations > that contained it, as it doesn't occur in the English version. > > The English file mixed tabs and spaces. Converted tabs to spaces for that > file. > > Stripped trailing whitespace from the English file. > > > This addresses bug STORM-1403. > http://jira.secondlife.com/browse/STORM-1403 > > > Diffs > ----- > > doc/contributions.txt 2204db549295 > indra/newview/skins/minimal/xui/da/panel_people.xml 2204db549295 > indra/newview/skins/minimal/xui/de/panel_people.xml 2204db549295 > indra/newview/skins/minimal/xui/en/panel_people.xml 2204db549295 > indra/newview/skins/minimal/xui/es/panel_people.xml 2204db549295 > indra/newview/skins/minimal/xui/fr/panel_people.xml 2204db549295 > indra/newview/skins/minimal/xui/it/panel_people.xml 2204db549295 > indra/newview/skins/minimal/xui/ja/panel_people.xml 2204db549295 > indra/newview/skins/minimal/xui/pl/panel_people.xml 2204db549295 > indra/newview/skins/minimal/xui/pt/panel_people.xml 2204db549295 > > Diff: http://codereview.secondlife.com/r/387/diff > > > Testing > ------- > > Switched to French, relogged, changed to default mode and logged out. Applied > this patch with -p3 to SecondLife-i686-2.7.5.233393/ (I'm using a downloaded > build, as I still cannot complete a build again.) > > Logged in, clicked 'Personnes' button, then 'MES AMIS' tab. The Call and > Teleport buttons were now labeled in French. > > Not tested: > * Funktionality of the buttons. > * Languages other than French. > > Update: > Tested "My Friends" tab of "People" floater (basic mode) in da, de, en, es, > fr, it, ja, pl and pt: > Verified for each language that > * labels on all 4 buttons on that tab are translated (or as translated as in > the XML files. "IM" seems to be the wanted label for the chat button in most > of them.) > * tool-tips of all 4 buttons are translated > * all 4 buttons cause the action they're intended to cause when clicked > > > Thanks, > > Boroondas > >
_______________________________________________ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
