----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/420/#review946 -----------------------------------------------------------
Ship it! Looks good to me. - Seth On July 28, 2011, 7:29 p.m., Vadim ProductEngine wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/420/ > ----------------------------------------------------------- > > (Updated July 28, 2011, 7:29 p.m.) > > > Review request for Viewer and Richard Nelson. > > > Summary > ------- > > Fixed broken localization of "Contents" and "New Script" items in the > Contents tab of Build Tools. > The bug happened when the translations contained non-ASCII characters. > > Reason: Names of inventory items are limited to ASCII characters. > Fix: Leave names in English, localize them when displaying (on the fly). > > The fix only affects object's inventory (i.e. not agent inventory). > > > This addresses bug STORM-1436. > http://jira.secondlife.com/browse/STORM-1436 > > > Diffs > ----- > > indra/newview/llpanelcontents.cpp 2f9a87538ca1 > indra/newview/llpanelobjectinventory.cpp 2f9a87538ca1 > indra/newview/llviewerobject.cpp 2f9a87538ca1 > > Diff: http://codereview.secondlife.com/r/420/diff > > > Testing > ------- > > Tested Japanese and Polish translations. The "Contents", "New Script", ""New > Script 1", "New Script 2", etc names were correctly localized. > > > Thanks, > > Vadim > >
_______________________________________________ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
