----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/433/#review963 -----------------------------------------------------------
indra/llui/llurlentry.cpp <http://codereview.secondlife.com/r/433/#comment990> This regexp will not allow nested tags. I'm not sure if we can handle or use nested tags, but it would seem to be better to use: boost::regex("<nolink>.?</nolink>") this will consume as few characters as possible between the opening and closing tags, thus allowing multiple "nolink"s - Richard On Aug. 10, 2011, 8:25 a.m., Vadim ProductEngine wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/433/ > ----------------------------------------------------------- > > (Updated Aug. 10, 2011, 8:25 a.m.) > > > Review request for Viewer and Richard Nelson. > > > Summary > ------- > > Disallow showing URL-like avatar display names as Web links in the > ShareItemsConfirmation notification. > > Updating the <nolink> tag parsing regexp to enable multiple > <nolink>...</nolink> clauses in a single textbox. > > > This addresses bug STORM-632. > http://jira.secondlife.com/browse/STORM-632 > > > Diffs > ----- > > indra/llui/llurlentry.cpp 99a6889a65ec > indra/newview/skins/default/xui/en/notifications.xml 99a6889a65ec > > Diff: http://codereview.secondlife.com/r/433/diff > > > Testing > ------- > > > Thanks, > > Vadim > >
_______________________________________________ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
