Heya Oz

Thanks for making Bos' hg hooks public!

I've looked at the unit test you've written for hg policy and have two
questions about it:

   1. Is it by purpose that the return code isn't checked after the hg
      policy invocation on line 23
      
<https://bitbucket.org/lindenlab/hg-tools/src/5ddf6f780503/tests/test-policies#cl-23>?
   2. On lines 75
      
<https://bitbucket.org/lindenlab/hg-tools/src/5ddf6f780503/tests/test-policies#cl-75>-77,
      is there a reason why you use cp rather than mv? I think the
      latter would avoid the need for the subsequent rm.

Cheers,
Boroondas
_______________________________________________
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Reply via email to