----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/516/#review1115 -----------------------------------------------------------
Just a few minor comments - looks very good. indra/newview/llfloaternamedesc.cpp <http://codereview.secondlife.com/r/516/#comment1087> for future reference, I'd prefer to see this as if/then/else with only one return, but this instance is so small that I don't feel too strongly about it. indra/newview/llpreviewscript.cpp <http://codereview.secondlife.com/r/516/#comment1088> Don't leave commented-out code in. indra/newview/llpreviewscript.cpp <http://codereview.secondlife.com/r/516/#comment1089> a comment here about why would be good ("user chose Cancel" ?) indra/newview/llpreviewscript.cpp <http://codereview.secondlife.com/r/516/#comment1090> user chose cancel? indra/newview/skins/default/xui/en/strings.xml <http://codereview.secondlife.com/r/516/#comment1091> fix indentation - Oz Linden On Dec. 8, 2011, 2:45 a.m., Ima Mechanique wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/516/ > ----------------------------------------------------------- > > (Updated Dec. 8, 2011, 2:45 a.m.) > > > Review request for Viewer. > > > Description > ------- > > Changes to allow opened script window to save/load to/from files on the users > computer. > > > This addresses bug https://jira.secondlife.com/browse/storm-1708. > > http://jira.secondlife.com/browse/https://jira.secondlife.com/browse/storm-1708 > > > Diffs > ----- > > doc/contributions.txt a1319d553db9 > indra/llui/lltexteditor.h a1319d553db9 > indra/llui/lltexteditor.cpp a1319d553db9 > indra/newview/llfilepicker.h a1319d553db9 > indra/newview/llfilepicker.cpp a1319d553db9 > indra/newview/llfloaternamedesc.h a1319d553db9 > indra/newview/llfloaternamedesc.cpp a1319d553db9 > indra/newview/llpreviewscript.h a1319d553db9 > indra/newview/llpreviewscript.cpp a1319d553db9 > indra/newview/llviewerfloaterreg.cpp a1319d553db9 > indra/newview/skins/default/xui/en/panel_script_ed.xml a1319d553db9 > indra/newview/skins/default/xui/en/strings.xml a1319d553db9 > > Diff: http://codereview.secondlife.com/r/516/diff/diff > > > Testing > ------- > > Successfully opened and saved scripts from/to local files. > > > Thanks, > > Ima Mechanique > >
_______________________________________________ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
