----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/563/ -----------------------------------------------------------
(Updated March 6, 2012, 10:31 p.m.) Review request for Viewer. Summary (updated) ----------------- VWR-23741: Fix for viewer crash when entering anything but a valid dns-address into the grid selection combo (login screen). Description ------- FIX FOR VWR-23741 (https://jira.secondlife.com/browse/vwr-23741) "Abnormal program termination when I enter an URL to the grid selection combobox (login-screen) and press enter." Repository with fix: https://bitbucket.org/MartinRJ/vwr-23741 About: When entering a malformed grid dns address, the viewer needs to catch the malformed address. Currently it throws an error in a subroutine of the grid-address-handling (llviewernetwork.cpp, function 'addGrid') and crashes without warning due to a thrown error ("throw LLInvalidGridName(grid);"). This fix adds code to: notifications.xml (a warning message text/notification: "IllegalGridName"), llviewernetwork.h (a function which checks whether a given grid exists, by name (string): bool getGridExists), llpanellogin.cpp (an include for llviewernetwork.h, and a check against an invalid grid dns address in function onSelectServer). Todo: Maybe edit the notification message, and update the language files. This addresses bug VWR-23741. http://jira.secondlife.com/browse/VWR-23741 Diffs ----- indra/llcommon/llversionviewer.h e9c82fca5ae6 Diff: http://codereview.secondlife.com/r/563/diff/diff Testing ------- Test plan: Insert a malformed grid dns address (e.g. http://grid.francogrid.org:8002 which works with some TPVs) into the grid selection combo on the login screen. Expected behaviour: a popup shows up, informing about the malformed address, and the grid selection combo swaps back to the default grid (Agni). Thanks, MartinRJ Fayray
_______________________________________________ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
