Wouldn't it be better if the crash could be reported anyway - just marking the correct version? With this in place at least crashes won't be misreported, but they also will be not reported to the servers at all, causing statistical deviation - what I believe is the core idea to be fixed. More comments in the JIRA,
Ricky Cron Stardust On Wed, Oct 31, 2012 at 6:42 PM, Oz Linden <o...@lindenlab.com> wrote: > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/607/ > Review request for Viewer. > By Oz Linden. > Description > > In all the marker files used to detect how the viewer run terminates, record > the version. When checking the results, report errors only if the current > version matches the version in the file. This prevents errors in one version > from being reported against the subsequent version. > > Testing > > Several simulated crashes both of the modified and unmodified viewers, and > some in which the marker file was modified manually to simulate different > viewers. Launched the new viewer after different crashes (and normal exits) > and confirmed (using logging temporarily added for that purpose) that the > reported last exec event was correct - and is always reported as Normal if > the previous version and the running version were not the same. > > *Bugs: * storm-1850 <http://jira.secondlife.com/browse/storm-1850> > Diffs > > - indra/newview/llappviewer.h (3d35a13561fc) > - indra/newview/llappviewer.cpp (3d35a13561fc) > > View Diff <http://codereview.secondlife.com/r/607/diff/> > > _______________________________________________ > Policies and (un)subscribe information available here: > http://wiki.secondlife.com/wiki/OpenSource-Dev > Please read the policies before posting to keep unmoderated posting > privileges >
_______________________________________________ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
