----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/609/ -----------------------------------------------------------
Review request for Viewer. Description ------- This is a fix for STORM-1854. It prevents an assert failure that happens during viewer startup on linux systems with a sufficiently new version of the fontconfig library (I think fontconfig 1.9). It should not impact mac or windows because those platforms do not use llwindowsdl.cpp file, which was the only file changed. This addresses bug STORM-1854. http://jira.secondlife.com/browse/STORM-1854 Diffs ----- indra/llwindow/llwindowsdl.cpp UNKNOWN Diff: http://codereview.secondlife.com/r/609/diff/ Testing ------- This change builds successfully on all three platforms (Teamcity). I have verified that the startup error no longer occurs on Ubuntu 12.10. Ideally we would test that Linux systems with older versions of fontconfig can also still start the viewer, but I don't have easy access to one of those. Thanks, Log Linden
_______________________________________________ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges