----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/611/#review1291 -----------------------------------------------------------
Ship it! Looks good to me. - Geenz Spad On Dec. 2, 2012, 2:53 a.m., Tofu Buzzard wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/611/ > ----------------------------------------------------------- > > (Updated Dec. 2, 2012, 2:53 a.m.) > > > Review request for Viewer. > > > Description > ------- > > Made deferred water use the atmospheric helper shader functions properly, > made fog calculation view-relative rather than absolute-position in deferred > and non-deferred windlight shaders. > > > This addresses bug OPEN-152. > http://jira.secondlife.com/browse/OPEN-152 > > > Diffs > ----- > > doc/contributions.txt UNKNOWN > indra/newview/app_settings/shaders/class1/deferred/waterF.glsl UNKNOWN > indra/newview/app_settings/shaders/class1/deferred/waterV.glsl UNKNOWN > indra/newview/app_settings/shaders/class1/environment/waterV.glsl UNKNOWN > indra/newview/llviewershadermgr.cpp UNKNOWN > > Diff: http://codereview.secondlife.com/r/611/diff/ > > > Testing > ------- > > Tested with/without deferred rendering, with various sky presets. > > > Screenshots > ----------- > > before/after comparisons > http://codereview.secondlife.com/r/611/s/1/ > > > Thanks, > > Tofu Buzzard > >
_______________________________________________ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
