Begin forwarded message:
Date: Wed, 02 Jul 2014 11:32:09 -0700 From: OnLive Jira Watcher <nore...@githooks.onlive.com.net> Subject: [git] Include Jira Ticket Number in Commits, Please! This notice is to remind you that you need to include valid Jira ticket numbers in all of your Git commits! We encountered the following problems in your recent commits. Commits with no reference to any jira tickets: https://github.onlive.com/Engineering/ol-secondlife/commit/3a5fae14 Clean up and rework FMOD.cmake and FindFMOD.cmake FMOD.cmake: Move include(Prebuilt) to prebuilt section. It is only used for prebuilt anyway. set(FMOD_FIND_REQUIRED ON) due to FMOD variable is use elsewhere in cmake files. This behaviour is the same as openal. Remove redudent error messages and code due to above. Rework the logic to be more cleaner. Clean up whitespace. FindFMOD.cmake Remove redudent paths as cmake allready uses them as default. Use PATH_SUFFIXES instead. The above will result in cmake looking in a lot more places and can handle custom build setups better. Change FMOD to FMOD_FOUND. FMOD should not be change withen cmake. Whitespace cleanup. -- https://github.onlive.com/Engineering/ol-secondlife/commit/ef220319 Allow the passing of addational fmod lib names via FMOD_NAMES from the build envorment. This will allow one to pass via command line custom fmod lib names. ie: -DFMOD_NAMES:STRING:"fmod-4.44" ----- Commits which reference invalid Jira ticket numbers that don't exist or have already been closed: https://github.onlive.com/Engineering/ol-secondlife/commit/999f782a SNOW-746: Finished Google BreakPad cmake for standalone (transplanted from 5a7ee78d029e973084e28d0d23a7233e0d976dca) --HG-- extra : transplant_source : Z%7E%E7%8D%02%9E%970%84%E2%8D%0D%23%A7%23%3E%0D%97m%CA -- https://github.onlive.com/Engineering/ol-secondlife/commit/a6def839 VWR-20893: "class Linux_x86_64Manifest" missing from viewer_manifest.py Breaking linux 64-bit build. (transplanted from 111a293c0e1c9062b1aa83dda7cf28aa22754930) --HG-- extra : transplant_source : %11%1A%29%3C%0E%1C%90b%B1%AA%83%DD%A7%CF%28%AA%22uI0 -- https://github.onlive.com/Engineering/ol-secondlife/commit/5ff89857 SNOW-599/SNOW-747: Pulseaudio should be optional on Linux. ----- Please be more careful in future commits. For information about installing the local onlive git hooks, which can help you remember, see https://wiki.onlive.com/display/DOCS/OnLive+Git+Hooks _______________________________________________ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
