https://bugzilla.mindrot.org/show_bug.cgi?id=2100
Bug ID: 2100
Summary: Missing dereference when bzeroing unused identities
Classification: Unclassified
Product: Portable OpenSSH
Version: 6.2p1
Hardware: Other
OS: Linux
Status: NEW
Severity: enhancement
Priority: P5
Component: ssh
Assignee: [email protected]
Reporter: [email protected]
Created attachment 2256
--> https://bugzilla.mindrot.org/attachment.cgi?id=2256&action=edit
Fix size passed to bzero
GCC 4.8 warns (for Debian package, so line numbers may be off from
mainline, sorry):
../sshconnect2.c: In function 'pubkey_prepare':
../sshconnect2.c:1527:20: warning: argument to 'sizeof' in 'bzero' call
is the same expression as the destination; did you mean to dereference
it? [-Wsizeof-pointer-memaccess]
bzero(id, sizeof(id));
It's correct; this code only zeroes the first sizeof(pointer) bytes of
the Identity structure, rather than the whole thing. Patch attached.
--
You are receiving this mail because:
You are watching the assignee of the bug.
_______________________________________________
openssh-bugs mailing list
[email protected]
https://lists.mindrot.org/mailman/listinfo/openssh-bugs