https://bugzilla.mindrot.org/show_bug.cgi?id=2463
Darren Tucker <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #2707|0 |1 is obsolete| | CC| |[email protected] --- Comment #4 from Darren Tucker <[email protected]> --- Created attachment 2708 --> https://bugzilla.mindrot.org/attachment.cgi?id=2708&action=edit shrink diff further by using #defines in openbsd-compat/glob.c That's certainly better. There's a couple of other ways to improve it: - the glob.c code will probably need syncing at some point too, albeit at a much lower rate than the mainline code. Using the #defines in there too removes a number diff lines. - I'd prefer the decision to use the system glob or not be taken early so that the logic remains central if globs appear elsewhere. (It's also the place we'd first look if glob appears in some other code). This seems to build warning-free and behave as expected on Linux using the compat libary: $ nm sftp | grep _compat_glob 00015570 T _compat_glob 00015800 T _compat_globfree and OpenBSD using the system library: $ nm sftp | grep "U glob" U glob U globfree Does this work for you? -- You are receiving this mail because: You are watching someone on the CC list of the bug. You are watching the assignee of the bug. _______________________________________________ openssh-bugs mailing list [email protected] https://lists.mindrot.org/mailman/listinfo/openssh-bugs
