https://bugzilla.mindrot.org/show_bug.cgi?id=2756

--- Comment #4 from willc...@google.com ---
Cool, thanks! I glanced briefly at the patch and it looks like it'll
definitely help. The minor nit I have is it could also update the
select timeout. It's OK as is, but it means that the
client_alive_check() may be called up to, in worst case, just under a
full ClientAliveInterval after it should. The worst case is when
writesetp is ready when (last_client_time +
options.client_alive_interval == monotime()), so it fails the 
(last_client_time + options.client_alive_interval < monotime()) check.
And then the next select() call times out after a full
ClientAliveInterval.

That's a nit. This fixes the bulk of the issue AFAICT. Thanks.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.
_______________________________________________
openssh-bugs mailing list
openssh-bugs@mindrot.org
https://lists.mindrot.org/mailman/listinfo/openssh-bugs

Reply via email to