https://bugzilla.mindrot.org/show_bug.cgi?id=2948
--- Comment #10 from Damien Miller <[email protected]> --- Comment on attachment 3345 --> https://bugzilla.mindrot.org/attachment.cgi?id=3345 sftp client copy-data extension This too looks good, minor comments: >diff --git a/sftp-client.c b/sftp-client.c >index 4986d6d8d291..cd2844a8585e 100644 >--- a/sftp-client.c >+++ b/sftp-client.c ... >+int >+do_copy(struct sftp_conn *conn, const char *oldpath, const char *newpath) >+{ ... >+ /* Silently return if the extension is not supported */ >+ if ((conn->exts & SFTP_EXT_COPY_DATA) == 0) { >+ error("Server does not support copy-data extension"); This is not silent :) >diff --git a/sftp.1 b/sftp.1 >index 0fd54cae090e..f2eae7f32790 100644 >--- a/sftp.1 >+++ b/sftp.1 ... >+.Ic lchdir , copy , chmod , chown , the manpage says the command is "copy", but ... >diff --git a/sftp.c b/sftp.c >index 7db86c2d3cf0..3288279172a9 100644 >--- a/sftp.c >+++ b/sftp.c ... >+ { "cp", I_COPY, REMOTE }, ... it's implemented as "cp" Either/both is fine, but it needs to be consistent of course. -- You are receiving this mail because: You are watching someone on the CC list of the bug. You are watching the assignee of the bug. _______________________________________________ openssh-bugs mailing list [email protected] https://lists.mindrot.org/mailman/listinfo/openssh-bugs
