https://bugzilla.mindrot.org/show_bug.cgi?id=3534
Darren Tucker <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #3679|ok?([email protected]) |ok+ Flags| | --- Comment #14 from Darren Tucker <[email protected]> --- Comment on attachment 3679 --> https://bugzilla.mindrot.org/attachment.cgi?id=3679 different approach Looks ok with a couple of nits. >+ static char buf[((sizeof(off_t) * 8 * 4 * 2) / 10) + 16]; What's the reasoning behind the numbers? >+ if (hours != 0) { >+ xextendf(&buf, NULL, "%d:%02d:%02d", >+ hours, minutes, seconds); >+ } else { >+ xextendf(&buf, NULL, " %02d:%02d", minutes, seconds); >+ } The rest of this function doesn't have brackets around single-line if/else statements. -- You are receiving this mail because: You are watching someone on the CC list of the bug. You are watching the assignee of the bug. _______________________________________________ openssh-bugs mailing list [email protected] https://lists.mindrot.org/mailman/listinfo/openssh-bugs
