Build Update for openssl/openssl ------------------------------------- Build: #15628 Status: Errored
Duration: 21 minutes and 15 seconds Commit: 7d46173 (master) Author: Matt Caswell Message: Revert BN_copy() flag copy semantics change Commit 9f9442918a changed the semantics of BN_copy() to additionally copy the BN_FLG_CONSTTIME flag if it is set. This turns out to be ill advised as it has unintended consequences. For example calling BN_mod_inverse_no_branch() can sometimes return a result with the flag set and sometimes not as a result. This can lead to later failures if we go down code branches that do not support constant time, but check for the presence of the flag. The original commit was made due to an issue in BN_MOD_CTX_set(). The original PR fixed the problem in that function, but it was changed in review to fix it in BN_copy() instead. The solution seems to be to revert the BN_copy() change and go back to the originally proposed way. Reviewed-by: Paul Dale <[email protected]> (Merged from https://github.com/openssl/openssl/pull/5080) View the changeset: https://github.com/openssl/openssl/compare/39571fcabf68...7d461736f7bd View the full build log and details: https://travis-ci.org/openssl/openssl/builds/329556049?utm_source=email&utm_medium=notification -- You can configure recipients for build notifications in your .travis.yml file. See https://docs.travis-ci.com/user/notifications
_____ openssl-commits mailing list To unsubscribe: https://mta.openssl.org/mailman/listinfo/openssl-commits
